This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Cdn check #14769
Closed
Cdn check #14769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had issues where the docs application has gone down because our build included invalid URLs to the production angular libraries. This change runs a subset of the docs e2e tests directly against these production libraries to ensure that they are accessible. If not then these tests will fail and the CI build will abort, preventing the docs app from being updated.
Previously it was slow and problematic to run builds if you were not connected to the internet because the build scripts make requests to github and the Google CDN to find out version information. You can now disable these requests by setting the ANGULAR_1_OFFLINE_BUILD environment variable to a truthy value.
|
OFFLINE is not 100% correct, it's more like NO_REMOTE_REQUESTS |
| @@ -39,7 +39,7 @@ describe('docs.angularjs.org', function () { | |||
|
|
|||
|
|
|||
| it('should change the page content when clicking a link to a service', function () { | |||
| browser.get('build/docs/index.html'); | |||
| browser.get('build/docs/index-production.html'); | |||
There was a problem hiding this comment.
So, by using -production we are not testing against our local build, but only against the CDN version, right?
This makes sense, since it is a separate app that just happens to live on the same repo and the app will use a CDN version (not our local build).
There was a problem hiding this comment.
Yes, so there are other tests in this folder that hit the normal index.html.
Also all the main e2e tests from the examples are run against local angular.
|
OK @Narretz, I can change that constant. Any other concerns? |
|
I'm still testing. |
Previously it was slow and problematic to run builds if you were not connected to the internet because the build scripts make requests to github and the Google CDN to find out version information. You can now disable these requests by setting the NG1_BUILD_NO_REMOTE_VERSION_REQUESTS environment variable to a non-empty value
|
|
||
| if (NO_REMOTE_REQUESTS) { | ||
| console.log('=============================================================================================='); | ||
| console.log('Running Offline:'); |
There was a problem hiding this comment.
"Running without getting remote tag and cdn version data"?
There was a problem hiding this comment.
"Running with no remote requests for version data"?
Previously it was slow and problematic to run builds if you were not connected to the internet because the build scripts make requests to github and the Google CDN to find out version information. You can now disable these requests by setting the NG1_BUILD_NO_REMOTE_VERSION_REQUESTS environment variable to a non-empty value
|
LGTM. Please be prepared for a follow-up that tries to make the "online" version work on Windows (because it doesn't like |
petebacondarwin
added a commit
that referenced
this pull request
Jun 15, 2016
We have had issues where the docs application has gone down because our build included invalid URLs to the production angular libraries. This change runs a subset of the docs e2e tests directly against these production libraries to ensure that they are accessible. If not then these tests will fail and the CI build will abort, preventing the docs app from being updated. Closes #14769
petebacondarwin
added a commit
that referenced
this pull request
Jun 15, 2016
Previously it was slow and problematic to run builds if you were not connected to the internet because the build scripts make requests to github and the Google CDN to find out version information. You can now disable these requests by setting the NG1_BUILD_NO_REMOTE_VERSION_REQUESTS environment variable to a non-empty value Closes #14769
petebacondarwin
added a commit
that referenced
this pull request
Jun 15, 2016
petebacondarwin
added a commit
that referenced
this pull request
Jun 15, 2016
We have had issues where the docs application has gone down because our build included invalid URLs to the production angular libraries. This change runs a subset of the docs e2e tests directly against these production libraries to ensure that they are accessible. If not then these tests will fail and the CI build will abort, preventing the docs app from being updated. Closes #14769
petebacondarwin
added a commit
that referenced
this pull request
Jun 15, 2016
Previously it was slow and problematic to run builds if you were not connected to the internet because the build scripts make requests to github and the Google CDN to find out version information. You can now disable these requests by setting the NG1_BUILD_NO_REMOTE_VERSION_REQUESTS environment variable to a non-empty value Closes #14769
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chores
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Nope
Please check if the PR fulfills these requirements
Other information:
Related to #14761