Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/filters): clarify when filters are executed #14758

Merged
merged 2 commits into from
Jun 15, 2016

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jun 13, 2016

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@@ -31,6 +31,16 @@ Filters may have arguments. The syntax for this is
E.g. the markup `{{ 1234 | number:2 }}` formats the number 1234 with 2 decimal points using the
{@link ng.filter:number `number`} filter. The resulting value is `1,234.00`.

### When filters are executed

In templates, filters are only executed when their inputs have changed. This is more performant than executing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify that this only applies to stateless filters (the default kind). Filters marked as stateful are called on every digest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I should mention this for completeness

@Narretz Narretz force-pushed the docs-filter-input branch from 9f634b9 to 5b8a290 Compare June 15, 2016 13:04
@gkalpak
Copy link
Member

gkalpak commented Jun 15, 2016

LGTM

@Narretz Narretz merged commit 40b657b into angular:master Jun 15, 2016
Narretz added a commit that referenced this pull request Jun 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants