This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngSanitize): call attribute setter in linky for all links #14710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-linky-attributes
branch
from
1f8a783 to
f8a5b2f
Compare
| @@ -141,6 +141,11 @@ angular.module('ngSanitize').filter('linky', ['$sanitize', function($sanitize) { | |||
| if (text == null || text === '') return text; | |||
| if (!isString(text)) throw linkyMinErr('notstring', 'Expected string but received: {0}', text); | |||
|
|
|||
| var attributesFn = | |||
| isFunction(attributes) ? attributes : | |||
| isObject(attributes) ? function getAttributesObject() {return attributes} : | |||
There was a problem hiding this comment.
Shouldn't these be angular.isObject and angular.isFunction ?
|
LGTM (except for the helper function |
Narretz
force-pushed
the
fix-linky-attributes
branch
from
f8a5b2f to
1b76a23
Compare
Narretz
force-pushed
the
fix-linky-attributes
branch
from
1b76a23 to
6249934
Compare
Narretz
added a commit
that referenced
this pull request
Jun 3, 2016
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Jun 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix
What is the current behavior? (You can also link to an open issue here)
Fixes #14707
Please check if the PR fulfills these requirements
Fixes #14707