This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($route): implement resolveRedirectTo
#14695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`resolveRedirectTo` can be set to a function that will (eventually) return the new URL to redirect to. The function supports dependency injection and should return the new URL either as a string or as a promise that will be resolved to a string. If the `resolveRedirectTo` function returns `undefined` or returns a promise that gets resolved to `undefined`, no redirection will take place and the current route will be processed normally. If the `resolveRedirectTo` function throws an error or the returned promise gets rejected, no further processing will take place (e.g. no template fetched, no `resolve` functions run, no controller instantiated) and a `$routeChangeError` will be broadcasted. `redirectTo` takes precedence over `resolveRedirectTo`, so specifying both on the same route definition, will cause the latter to be ignored. Fixes angular#5150 BREAKING CHANGE: Previously, if `redirectTo` was a function that threw an Error, execution was aborted without firing a `$routeChangeError` event. Now, if a `redirectTo` function throws an Error, a `$routeChangeError` event will be fired.
gkalpak
force-pushed
the
feat-ngRoute-injectable-async-redirectTo
branch
from
22c991f to
0f5c1cf
Compare
|
We could avoid the BC, but the previous behavior feels like an oversight. |
|
|
||
| module(function($routeProvider) { | ||
| $routeProvider.when('/bar/:id/:subid/:subsubid', {templateUrl: 'bar.html'}); |
There was a problem hiding this comment.
I assume that you removed this line because it is not used in the test, right?
|
A few nit-picks but otherwise LGTM for 1.6 |
|
Thx for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
It is not possible to have a redirection gunction that is injectable and asynchronous (i.e. returns a promise).
See #5150.
What is the new behavior (if this is a feature change)?
resolveRedirectTocan be used to provide an injectable, possibly asynchronous redirection function.Does this PR introduce a breaking change?
Yes (see below).
Please check if the PR fulfills these requirements
Other information:
resolveRedirectTocan be set to a function that will (eventually) return the new URL to redirectto. The function supports dependency injection and should return the new URL either as a string or
as a promise that will be resolved to a string.
If the
resolveRedirectTofunction returnsundefinedor returns a promise that gets resolved toundefined, no redirection will take place and the current route will be processed normally.If the
resolveRedirectTofunction throws an error or the returned promise gets rejected, nofurther processing will take place (e.g. no template fetched, no
resolvefunctions run, nocontroller instantiated) and a
$routeChangeErrorwill be broadcasted.redirectTotakes precedence overresolveRedirectTo, so specifying both on the same routedefinition, will cause the latter to be ignored.
Fixes #5150
BREAKING CHANGE:
Previously, if
redirectTowas a function that threw an Error, execution was aborted without firinga
$routeChangeErrorevent.Now, if a
redirectTofunction throws an Error, a$routeChangeErrorevent will be fired.