This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): don't break on anchored animations without duration #14645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am pretty sure there is a better way to test this. /cc @Narretz |
|
What exactly don't you like about the test? |
| @@ -13,7 +13,7 @@ describe("animations", function() { | |||
| }; | |||
| })); | |||
|
|
|||
| afterEach(inject(function($$jqLite) { | |||
| afterEach(inject(function() { | |||
There was a problem hiding this comment.
What is going on here? Do we actually need an inject call at all?
There was a problem hiding this comment.
I guess we don't 😃 I missed it.
|
LGTM |
petebacondarwin
pushed a commit
that referenced
this pull request
May 22, 2016
If the `from` element of an animation does not actually have an animation then there will be no animation runner on that element. This is possible if the element has the `ng-animate-ref` attribute but does not have any CSS animations or transitions defined. In this case, it is not necessary to try to update the host of the non-existent runner. Fixes #14641 Closes #14645
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
#14641
What is the new behavior (if this is a feature change)?
Anchored animations (via
[ng-animate-ref]) without duration, don't break.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #14641