Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Updated ngAnimate docs #14586

Closed
wants to merge 1 commit into from
Closed

Updated ngAnimate docs #14586

wants to merge 1 commit into from

Conversation

peebeebee
Copy link
Contributor

@peebeebee peebeebee commented May 11, 2016

We can remove the vendor-prefixing from our docs, since all new browsers support these properties.
The transition property should be set as follows... transition:

We can remove the vendor-prefixing from our docs, since all new browsers support these properties.
The transition property should be set as follows... transition: <transition-property> <transition-duration>  <transition-timing-function> <transition-delay>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@peebeebee
Copy link
Contributor Author

I signed it!

On Wed, May 11, 2016 at 4:54 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14586 (comment)

Peter Briers, Freelance front-ender
tel: +32 499 16 58 94 × web: http://peterbriers.be × twitter: @pbriers
× skype: peter.briers

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented May 12, 2016

Thanks for the PR. I think we should still add a note somewhere that you will have to add vendor-specific prefixes if you plan to support old browser versions.

@Narretz Narretz added this to the Backlog milestone May 12, 2016
@peebeebee
Copy link
Contributor Author

I see that I did the PR to master. Is this OK?

@Narretz
Copy link
Contributor

Narretz commented May 12, 2016

Yes, that's okay. We will backport as appropriate.

@Narretz
Copy link
Contributor

Narretz commented May 19, 2016

Can you please add a note that you will have to add vendor-specific prefixes if you plan to support old browser versions?

petebacondarwin pushed a commit that referenced this pull request May 25, 2016
We can remove the vendor-prefixing from our docs, since all major browsers
support these properties, without prefixes.

Closes #14586
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants