-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix passing eventHandlers when passThrough #14471
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thanks for the PR! Good catch. Can you please update these 2 tests, too? angular.js/test/ngMock/angular-mocksSpec.js Lines 2135 to 2150 in e14b486
|
yes, tests updated |
Bug fix
This commit fix passing eventHandlers and uploadEventHandlers when using angular.mock
Need to fix function arguments in tests: angular.js/test/ngMock/angular-mocksSpec.js