Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($http): Corrects a typo #14430

Closed
wants to merge 1 commit into from

Conversation

cloverharvest
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Missing letter: seeing 'his', instead of the word 'this'

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

No, but corrects documentation. And makes it cleaner.

Please check if the PR fulfills these requirements

Other information:

Correcting a typo line 558: To prevent "this" as a proposed replacement to prevent "his".

Correcting a typo line 558: To prevent this to replace to prevent his.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Apr 14, 2016

Thx for the PR. You need to have signed the CLA, before we can merge this.
(It's a one-of process and pretty straight-forward 😃)

@cloverharvest
Copy link
Contributor Author

I signed it.

Contributor License Agreements
Individual Agreements

Individual agreements we have on file for you:

Agreement Name Date Signed Manage
Google Individual CLA Anna P. Schwab Apr 14, 2016 09:14 PDT Edit Contact
Information

On Wed, April 13, 2016 6:40 pm, googlebot wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub
    username or you're using a different email address. Check your existing
    CLA data
    and verify that your
    email is set on your git
    commits
    .
  • If you signed the CLA as a corporation, please let us know the company's
    name.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#14430 (comment)

Kind regards,

Anna P. Schwab

code. apps. web

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@cloverharvest
Copy link
Contributor Author

cloverharvest commented Apr 14, 2016

Hello Georgios,

I signed it.

Contributor License Agreements
Individual Agreements

Individual agreements we have on file for you:

Agreement Name Date Signed Manage
Google Individual CLA Anna P. Schwab Apr 14, 2016 09:14 PDT Edit Contact
Information

If there's any confusion my associated email for google is CENSORED
but my github cloverharvest is with CENSORED.

We're learning Angular now.

Thanks,

Anna

On Thu, April 14, 2016 12:34 pm, Georgios Kalpakas wrote:

Thx for the PR. You need to have signed the CLA, before we can merge
this. (It's a one-of process and pretty straight-forward
😃)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#14430 (comment)

Kind regards,

Anna P. Schwab

code. apps. web

@gkalpak gkalpak closed this in b4c7df3 Apr 14, 2016
gkalpak pushed a commit that referenced this pull request Apr 14, 2016
gkalpak pushed a commit that referenced this pull request Apr 14, 2016
@gkalpak
Copy link
Member

gkalpak commented Apr 14, 2016

You are a contributor now 😎
Thx !

@cloverharvest
Copy link
Contributor Author

Awesome! Thanks, Georgios!

Sent from my iPhone

On Apr 14, 2016, at 3:30 PM, Georgios Kalpakas notifications@github.com wrote:

You are a contributor now
Thx !


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants