This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($componentController): provide isolated scope if none is passed #14425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| locals = {}; | ||
| } | ||
| if (!locals.$scope) { | ||
| locals.$scope = locals.$scope || $rootScope.$new(true); |
There was a problem hiding this comment.
Isn't locals.$scope || redundant here?
There was a problem hiding this comment.
Oops yes. Good spot
| // check it is isolated | ||
| $rootScope.a = 17; | ||
| $ctrl.$scope.a = 42; | ||
| expect($rootScope.a).toEqual(17); |
There was a problem hiding this comment.
Won't this work with non-isolate scope as well ?
There was a problem hiding this comment.
Oh yeah. I mean to check that $scope.a was undefined too.
|
LGTM |
petebacondarwin
added a commit
that referenced
this pull request
Apr 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat
What is the current behavior? (You can also link to an open issue here)
one must always provide a scope for the $componentController helper, which is annoying
What is the new behavior (if this is a feature change)?
now an isolated child of rootScope is created and used if no scope is provided
Does this PR introduce a breaking change?
Nope
Please check if the PR fulfills these requirements
Other information: