This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): do not use noop() as controller for multiple components
#14402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, custom annotations are copied from the CDO onto the controller constructor. Using `noop()` when no controller has been specified, pollutes it with custom annotations and makes one component's annotations available to all other components that have `noop()` as their controller. Fixes angular#14391
gkalpak
force-pushed
the
fix-compile-registerComponent-pollutes-noop
branch
from
1b4b1a2 to
0342db2
Compare
| module('my', []). | ||
| component('myComponent1', {$customAnnotation1: 'XXX'}). | ||
| component('myComponent2', {$customAnnotation2: 'YYY'}); | ||
| module('my'); |
There was a problem hiding this comment.
There should be a newline before and after this line for readability.
|
LGTM, apart from a nitpick |
petebacondarwin
pushed a commit
that referenced
this pull request
Apr 11, 2016
Currently, custom annotations are copied from the CDO onto the controller constructor. Using `noop()` when no controller has been specified, pollutes it with custom annotations and makes one component's annotations available to all other components that have `noop()` as their controller. Fixes #14391 Closes #14402
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
#14391
What is the new behavior (if this is a feature change)?
A new function is used as controller for each component that does not specify one.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Currently, custom annotations are copied from the CDO onto the controller constructor.
Using
noop()when no controller has been specified, pollutes it with custom annotations and makes one component's annotations available to all other components that havenoop()as their controller.Fixes #14391