Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($httpBackend): updated response data api #14346

Closed
wants to merge 1 commit into from

Conversation

robinj
Copy link
Contributor

@robinj robinj commented Mar 30, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update

What is the current behavior? (You can also link to an open issue here)
Missing return type in documentation for httpBackend requestHandler function

What is the new behavior (if this is a feature change)?
Added missing return type in documentation

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

Updated docs to reflect that response data can either be an object or a string

Updated docs to reflect that response data can either be an object _or_ a string
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@robinj
Copy link
Contributor Author

robinj commented Mar 30, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz self-assigned this Apr 7, 2016
@Narretz Narretz closed this in fd0b1eb Apr 7, 2016
Narretz pushed a commit that referenced this pull request Apr 7, 2016
Updated docs to reflect that response data can either be an array, object _or_ a string
Technically, response data can be anything that can be handled by angular.copy,
but since string and JSON data is most commonly mocked, the main types are sufficient.

Closes #14346
@robinj robinj deleted the patch-1 branch April 7, 2016 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants