Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Internet Explorer Compatibility): Add ng-attr-type workaround for buttons in IE #14119

Closed
wants to merge 1 commit into from
Closed

docs(guide/Internet Explorer Compatibility): Add ng-attr-type workaround for buttons in IE #14119

wants to merge 1 commit into from

Conversation

SteveShaffer
Copy link
Contributor

Resolves #14117

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SteveShaffer
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

Narretz
Narretz reviewed Feb 24, 2016
View reviewed changes
docs/content/guide/ie.ngdoc
but does not work in Internet Explorer <= 11 (the most recent version at time of writing).
2. For buttons, use `ng-attr-type` tags instead of `type="{{ someExpression }}"`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For the type attribute of buttons, use ..."

@SteveShaffer
Copy link
Contributor Author

Incorporated comment and squashed commits

petebacondarwin pushed a commit that referenced this pull request Feb 24, 2016
@SteveShaffer @petebacondarwin
docs(guide/Internet Explorer Compatibility): Add ng-attr-type workaro…
2684444 
…und for buttons in IE

Closes #14117
Closes #14119
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveShaffer @googlebot @Narretz