-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($compile): handle boolean attributes in @
bindings
#14070
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Good catch 👍 (This has been on my TODO list for a while 😃)
Feel free to ping me when/if you make any changes, so I can take another look 😉 |
@gkalpak just signed the CLA a few minutes ago. A test was already added back in February. |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Rebased to current master and manually resolved conflicts with 874c0fd |
Commit db5e0ff handles initial values of boolean attributes. The same change needs to be applied inside the attrs.$observe() call.
Commit db5e0ff handles initial values of boolean attributes. The same
change needs to be applied inside the attrs.$observe() call.
(I'm not familiar with the angular.js codebase, so this may not be the right way to fix the issue. What I verified is that this fixes a regression with some production code which worked with angular.js 1.2.28 and 1.3.20 but failed with 1.4.7.
So feel free to replace this PR with some better fix, as you like.)