Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Only call console.log when available #14047

Merged
merged 2 commits into from
Feb 16, 2016
Merged

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Feb 15, 2016

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

Narretz pushed a commit to Narretz/angular.js that referenced this pull request Feb 15, 2016
`window.console` only exists in IE 8 & 9 when the devtools are open

Fixes angular#14006
Closes angular#14007
Closes angular#14047
@petebacondarwin
Copy link
Contributor

LGTM

lucienbertin and others added 2 commits February 16, 2016 17:00
`window.console` only exists in IE 8 & 9 when the devtools are open

Fixes angular#14006
Closes angular#14007
Closes angular#14047
When Angular is loaded more than once (by including the script multiple times),
a warning is logged in the console. IE9 only makes the console available when
the dev tools are open, so before this fix, the browser would throw an error

Note that Protractor doesn't actually support IE9.
@Narretz Narretz merged commit 3940edc into angular:master Feb 16, 2016
Narretz pushed a commit that referenced this pull request Feb 16, 2016
`window.console` only exists in IE 8 & 9 when the devtools are open

Fixes #14006
Closes #14007
Closes #14047
Narretz pushed a commit that referenced this pull request Feb 16, 2016
`window.console` only exists in IE 8 & 9 when the devtools are open

Fixes #14006
Closes #14007
Closes #14047
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants