Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngValue): set value property instead of attribute #14023

Closed
wants to merge 1 commit into from

Conversation

m-amr
Copy link
Contributor

@m-amr m-amr commented Feb 12, 2016

in case of input element set value usering property instead of attribute
fixed #13984

@m-amr m-amr force-pushed the fix_ng-value branch 4 times, most recently from 2ee1c0e to b895c80 Compare February 13, 2016 00:14
in case of input element set value using property instead of attribute
fixed angular#13984
@gkalpak
Copy link
Member

gkalpak commented Feb 13, 2016

I don't think this is the right fix. The behavior of $set should not be changed imo.
The change must be local to ngValue.

@gkalpak gkalpak added this to the Ice Box milestone Feb 13, 2016
@gkalpak gkalpak self-assigned this Feb 13, 2016
@m-amr
Copy link
Contributor Author

m-amr commented Feb 13, 2016

@gkalpak ,
Thanks for replying.
I tried to solve the problem inside the $set so it can be used in any other place,
and i followed the same way that the set method used to handle boolean values
snipped from $set method

   if (booleanKey) {
      this.$$element.prop(key, value);
      attrName = booleanKey;
    } else if (aliasedKey) {
      this[aliasedKey] = value;
      observer = aliasedKey;
    }

but based on your opinion That the change must be local to ngValue
this pull request
#14031

I solved the problem locally to ngValueDirective
could you please check it.
Thanks

@gkalpak
Copy link
Member

gkalpak commented Feb 13, 2016

Closing in favor of #14031.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngValue one way binding?
3 participants