Bugfix - Typos #13507
Bugfix - Typos #13507
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| @@ -47,7 +47,7 @@ install: | |||
| # Log HTTP requests | |||
| - npm config set loglevel http | |||
| - npm install -g npm@2.5 | |||
| # Instal npm dependecies and ensure that npm cache is not stale | |||
| # Instal npm dependencies and ensure that npm cache is not stale | |||
There was a problem hiding this comment.
There' also instal -> install
There was a problem hiding this comment.
Haha, missed this one!
jutaz
force-pushed
the
bugfix/typo-fixes
branch
from
e0bdaa5 to
99a154d
Compare
|
Amended to include |
| @@ -261,7 +261,7 @@ function computeCssStyles($window, element, properties) { | |||
| } | |||
|
|
|||
| // by setting this to null in the event that the delay is not set or is set directly as 0 | |||
| // then we can still allow for zegative values to be used later on and not mistake this | |||
| // then we can still allow for negative values to be used later on and not mistake this | |||
There was a problem hiding this comment.
Maybe zegative means zero or negative 😛
There was a problem hiding this comment.
But from what I understand, zero values are being set to null, right? So in that case zero is not allowed 😉
There was a problem hiding this comment.
Yes, but it could be a bug in the code and not a typo in the docs 😛
Just kidding...
There was a problem hiding this comment.
Haha, that would be bad
|
Nice one ! I favour (pun intended) |
Yeah, but given that this project is |
|
BTW this is not "backportable" to Thx for all the typo crashing so far 👍 |
This PR fixes few typo found around the place