This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngMock) add atomic flushing strategy for $timeout #13146
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear angular community,
During writing unit-tests I found one interesting issue. I need to write tests for some code like this:
And I'm expecting that i need to execute
$timeout.flush()
2 times. First time to reachaction1
function and the second time to executeaction2
function (let's call this kind of flush "atomic" for example). But for now, for the first flush() it executes the both handlers. One after another. Please check this example: http://jsbin.com/fuziri/edit?js,output .At the other hand we have some cases in tests when this buggy, for the first look, behaviour can simplify our lifes. In such case for example:
Here
$timeout
register new defered task to process callback using$browser.defer
during flushing. So to execute callback (if you are using that atomic flush strategy) you should call$timeout.flush()
twise.I think that the both strategies of flushing are pretty useful. And may be it will be a good idea to allow to switch between them, using some additional parameter.
I implemented solution which works for me. What do you think about this?