Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Essential note when cloning into Angular repository #12875

Closed
wants to merge 2 commits into from

Conversation

SibuStephen
Copy link
Contributor

  1. First change - Whenever cloning into directory there are chances of some users using "sudo" without knowing what it does exactly and what's the purpose of using sudo, leading them into a confusion and this lead to changes in git config and permission issues of which users may not be able to figure out at one spot.
  2. Second Change- There are chances of version unstability issues in node which at times causes npm error and warnings while installing packages, I too had undergone some issues with node version conflicts at times, users who are not aware of this will be benefited with a Note prior.

1) First change - Whenever cloning into directory there are chances of some users using "sudo" without knowing what it does exactly and what's the purpose of using sudo, leading them into a confusion and this lead to changes in git config and permission issues of which users may not be able to figure out at one spot.
2)  Second Change- There are chances of version unstability  issues in node which at times causes npm error and warnings while installing packages, I too had undergone some issues with node version conflicts at times, users who are not aware of this will be benefited with a Note prior.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SibuStephen
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@@ -61,7 +61,8 @@ To build AngularJS, you clone the source code repository and use Grunt to genera
minified AngularJS files:

```shell
# Clone your Github repository:
# Clone your Github repository(Note: Do not go with `sudo` user when cloning into this repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it as particularly helpful to tell the user not to use sudo even though this point doesn't mention sudo at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i totally agree with you @Narretz , but won't it be a before hand note to tell the users that using sudo might not be good always, if in case they use it to clone the repo and are not even aware of what exactly it does?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really provide a documentation for unix-specific commands. If somebody uses sudo to clone the repo, they should know what they are doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Narretz ok will do, you are right I will remove it, and is my second comment valid? please do provide feedback. Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can't hurt to add the link to the sudo man page to the first mention of sudo on the page on line 49.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I include that and replace with the original Note (Do not go with sudo user when cloning into this repository ) ?

@Narretz Narretz added this to the Backlog milestone Sep 19, 2015
@Narretz
Copy link
Contributor

Narretz commented May 24, 2016

I've checked the docs again and both a note for sudo / admin, and the required node version has been added in the meantime.

@Narretz Narretz closed this May 24, 2016
Narretz pushed a commit that referenced this pull request May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants