-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Essential note when cloning into Angular repository #12875
Conversation
SibuStephen
commented
Sep 17, 2015
- First change - Whenever cloning into directory there are chances of some users using "sudo" without knowing what it does exactly and what's the purpose of using sudo, leading them into a confusion and this lead to changes in git config and permission issues of which users may not be able to figure out at one spot.
- Second Change- There are chances of version unstability issues in node which at times causes npm error and warnings while installing packages, I too had undergone some issues with node version conflicts at times, users who are not aware of this will be benefited with a Note prior.
1) First change - Whenever cloning into directory there are chances of some users using "sudo" without knowing what it does exactly and what's the purpose of using sudo, leading them into a confusion and this lead to changes in git config and permission issues of which users may not be able to figure out at one spot. 2) Second Change- There are chances of version unstability issues in node which at times causes npm error and warnings while installing packages, I too had undergone some issues with node version conflicts at times, users who are not aware of this will be benefited with a Note prior.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it |
CLAs look good, thanks! |
@@ -61,7 +61,8 @@ To build AngularJS, you clone the source code repository and use Grunt to genera | |||
minified AngularJS files: | |||
|
|||
```shell | |||
# Clone your Github repository: | |||
# Clone your Github repository(Note: Do not go with `sudo` user when cloning into this repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see it as particularly helpful to tell the user not to use sudo even though this point doesn't mention sudo at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i totally agree with you @Narretz , but won't it be a before hand note to tell the users that using sudo might not be good always, if in case they use it to clone the repo and are not even aware of what exactly it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't really provide a documentation for unix-specific commands. If somebody uses sudo
to clone the repo, they should know what they are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Narretz ok will do, you are right I will remove it, and is my second comment valid? please do provide feedback. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can't hurt to add the link to the sudo man page to the first mention of sudo on the page on line 49.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I include that and replace with the original Note (Do not go with sudo
user when cloning into this repository ) ?
I've checked the docs again and both a note for sudo / admin, and the required node version has been added in the meantime. |