Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Corrected date format for Portuguese (both locales) #11925

Closed
wants to merge 2 commits into from

Conversation

rafasoares
Copy link

Short date formats in Portuguese (both in Portugal and Brazil) are expressed as dd/MM/yyyy (http://en.wikipedia.org/wiki/Date_format_by_country). I've updated the symbols to reflect that.

Review on Reviewable

Short date formats in Portuguese (both in Portugal and Brazil) are expressed as dd/MM/yyyy (http://en.wikipedia.org/wiki/Date_format_by_country). I've updated the symbols to reflect that.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

I've missed the specific pt-PT locale in my last commit.
@googlebot
Copy link

CLAs look good, thanks!

@lgalfaso
Copy link
Contributor

lgalfaso commented Jun 1, 2015

The locales are generated automatically from https://github.com/google/closure-library/blob/master/closure/goog/i18n/datetimesymbols.js please post your patch there.
I will keep this issue open to track the generation of the locales once this is fixed there.

@rafasoares
Copy link
Author

Ok, I've submitted a pull resquest there as well.

Thanks!

@petebacondarwin
Copy link
Contributor

@lgalfaso rather than leaving this issue open, I am going to close it; @rafasoares please open a new issue once the locales have been updated in closure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants