This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($http): clarify side effects of transformRequest functions #11503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'X-MY_HEADER': 'abcd' | ||
| }); | ||
| } | ||
| return angular.isObject(data) ? angular.toJson(data) : data; |
There was a problem hiding this comment.
Could be shortened to just return data, or just insert ... since it's not the main point of the example
|
Otherwise LGTM |
|
Thnx for the review @Narretz - will fix things up and merge! |
pkozlowski-opensource
force-pushed
the
issue11438
branch
from
a6289ee to
a9e2f15
Compare
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11438