Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(select): remove unknown option when model is undefined and empty option is available #11092

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ng/directive/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ var SelectController =
if (value === '') self.emptyOption.prop('selected', true); // to make IE9 happy
} else {
if (isUndefined(value) && self.emptyOption) {
self.removeUnknownOption();
$element.val('');
} else {
self.renderUnknownOption(value);
Expand Down
17 changes: 17 additions & 0 deletions test/ng/directive/selectSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,23 @@ describe('select', function() {
});


it('should remove unknown option when model is undefined', function() {
scope.robot = 'other';
compile('<select ng-model="robot">' +
'<option value="">--select--</option>' +
'<option value="x">robot x</option>' +
'<option value="y">robot y</option>' +
'</select>');

expect(element).toEqualSelect([unknownValue('other')], '', 'x', 'y');

scope.robot = undefined;
scope.$digest();

expect(element).toEqualSelect([''], 'x', 'y');
});


describe('interactions with repeated options', function() {

it('should select empty option when model is undefined', function() {
Expand Down