This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fixing ng-jq bug with using getNgAttribute before jqLite variable is set #11027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of timed out tests again. Can someone see what's going on please? |
|
I don't know about the timed out tests, but maybe it helps if you clean up the PR (put the fix on a new branch or make sure it sits exactly on top of master, so these other commits don't get in the way. |
|
And I think if you force push the branch, it will trigger another travis run. For the tests, maybe we should do an end2end test? |
|
Sorry, I resetted my fork to the upstream/master and added the change to it, but in the process it closed this PR. New PR was created: #11044 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests wasn't able to catch this unless it's on a 'fresh' angular page with ng-jq already added before angular bootstrapping. I've removed the need for jq() to rely on getNgAttribute and instead using element.getAttribute function with the found prefix.
Could use some direction on how to test ng-jq more thoroughly so this doesn't happen again in the future.
This fixes issue #11016.