docs(date): Change milliseconds pagging syntax #10680
Conversation
Change millisecond pagging syntax : no need to prefix with ',' or '.'.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Contributor License Agreement Signed ! |
|
CLAs look good, thanks! |
| @@ -361,7 +361,7 @@ var DATE_FORMATS_SPLIT = /((?:[^yMdHhmsaZEw']+)|(?:'(?:[^']|'')*')|(?:E+|y+|M+|d | |||
| * * `'m'`: Minute in hour (0-59) | |||
| * * `'ss'`: Second in minute, padded (00-59) | |||
| * * `'s'`: Second in minute (0-59) | |||
| * * `'.sss' or ',sss'`: Millisecond in second, padded (000-999) | |||
| * * `'sss' or 'sss'`: Millisecond in second, padded (000-999) | |||
There was a problem hiding this comment.
Not sure if this change is correct, but if it is, then only one 'sss' is needed.
(I.e. the or 'sss' part can be removed.)
fix doc modif according to @gkalpak comment
|
Thanks @gkalpak. To complete the reason why |
There is no need to prefix 'sss' with ',' or '.'. Closes #10680
Change millisecond pagging syntax : no need to prefix with ',' or '.'.