perf($compile): only re-$interpolate attribute values at link time if changed since compile #10411

jbedard · 2014-12-11T06:35:46Z

This makes the added benchmark case

create step ~3x faster
create step consumes half the memory (and half the garbage collected on destroy step)
GC times in all 3 steps are about 30-50% less

googlebot · 2014-12-11T06:35:47Z

CLAs look good, thanks!

… changed since compile

lgalfaso · 2014-12-11T19:08:38Z

LGTM, will aim at merging this for 1.3.7

lgalfaso · 2014-12-13T11:57:03Z

landed as 9ae0c01

googlebot added the cla: yes label Dec 11, 2014

jbedard mentioned this pull request Dec 11, 2014

refactor($interpolate): remove some unnecessary logic, move functions out of closure #10413

Closed

jbedard force-pushed the interp-attr-avoid-reinterp branch 3 times, most recently from 8699d5c to d104133 Compare December 11, 2014 08:06

perf($compile): only re-$interpolate attribute values at link time if…

49211af

… changed since compile

jbedard force-pushed the interp-attr-avoid-reinterp branch from d104133 to 49211af Compare December 11, 2014 08:12

lgalfaso added this to the 1.3.7 milestone Dec 11, 2014

lgalfaso self-assigned this Dec 11, 2014

lgalfaso added component: misc core type: feature type: perf and removed type: feature labels Dec 11, 2014

lgalfaso closed this Dec 13, 2014

Provide feedback