Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($http): avoid using closure vars in serverRequest fn #10361

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/ng/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -738,23 +738,22 @@ function $HttpProvider() {
</example>
*/
function $http(requestConfig) {
var config = {
method: 'get',
transformRequest: defaults.transformRequest,
transformResponse: defaults.transformResponse
};
var headers = mergeHeaders(requestConfig);

if (!angular.isObject(requestConfig)) {
throw minErr('$http')('badreq', 'Http request configuration must be an object. Received: {0}', requestConfig);
}

extend(config, requestConfig);
config.headers = headers;
var config = extend({
method: 'get',
transformRequest: defaults.transformRequest,
transformResponse: defaults.transformResponse
}, requestConfig);

config.headers = mergeHeaders(requestConfig);
config.method = uppercase(config.method);

var serverRequest = function(config) {
headers = config.headers;
var headers = config.headers;
var reqData = transformData(config.data, headersGetter(headers), config.transformRequest);

// strip content-type if data is undefined
Expand Down