feat(jsonFilter): add optional arg to define custom indentation #10297
Conversation
also change toJson function to accomodate passing in of number of spaces Closes angular#9771
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@petebacondarwin / @lgalfaso can you double check this for me? There was a small breaking change in the original CL, but fixing it makes the code maybe bigger than we'd like --- so I'll let you make the call on whether we want to do that. Realistically, the impact of the break is pretty minimal. Either way, I want the extra tests. |
| * @returns {string|undefined} JSON-ified string representing `obj`. | ||
| */ | ||
| function toJson(obj, pretty) { | ||
| if (typeof obj === 'undefined') return undefined; | ||
| return JSON.stringify(obj, toJsonReplacer, pretty ? ' ' : null); | ||
| if (typeof pretty !== "number") { |
There was a problem hiding this comment.
I always prefer to use the helpers (isNumber()).
(And even if you choose not to, using single quotes is more consistent.)
There was a problem hiding this comment.
yeah true --- I dunno if we need to do this or not anyway though, like I said it's a pretty low-impact breaking change
|
otherwise, LGTM |
|
Good work all! |
No description provided.