Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($http): fixes grunt warning #10270

Closed
wants to merge 2 commits into from
Closed

docs($http): fixes grunt warning #10270

wants to merge 2 commits into from

Conversation

jesselpalmer
Copy link
Member

When you run grunt package you get the following warning:

warn:    Dangling Links Found in "partials/api/ng/service/$http.html":
 - #overriding-the-default-transformations-per-request,
 - #overriding-the-default-transformations-per-request

This change fixes the links, so the warning will no longer appear.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@jesselpalmer
Copy link
Member Author

I've signed the CLA before. My email address in the CLA contains dots in it and the email address that I use for my git commits does not. I'll update the email address for my git commits so they match.

@@ -610,12 +610,14 @@ function $HttpProvider() {
* `{function(data, headersGetter)|Array.<function(data, headersGetter)>}` –
* transform function or an array of such functions. The transform function takes the http
* request body and headers and returns its transformed (typically serialized) version.
* See {@link #overriding-the-default-transformations-per-request Overriding the Default Transformations}
* See {@link api/ng/service/$http#overriding-the-default-transformations-per-request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to just use ng.$http#... for this instead --- but it basically looks good, will merge it tonight if nobody else beats me to it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@jesselpalmer
Copy link
Member Author

I updated my email on my git commit and I guess the googlebot didn't like that too much. I made the changes as you requested though. Thanks @caitp!

@jesselpalmer jesselpalmer deleted the fixes-grunt-warning branch November 30, 2014 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants