style(*): IE is a real browser, and chakra is pretty solid #10242
Conversation
|
CLAs look good, thanks! |
caitp
changed the title
|
Ping @petebacondarwin I just did a quick grep through the codebase, I might have missed some --- want to take another look? |
| @@ -40,7 +40,6 @@ var scriptDirective = ['$templateCache', function($templateCache) { | |||
| compile: function(element, attr) { | |||
| if (attr.type == 'text/ng-template') { | |||
| var templateUrl = attr.id, | |||
| // IE is not consistent, in scripts we have to read .text but in other nodes we have to read .textContent | |||
There was a problem hiding this comment.
This comment does not make sense, since text is IDL-exposed for HTMLScriptElement, and we're using it in all cases anyways.
|
otherwise, LGTM |
- IE9+ do not have issues with Function.prototype.apply() on builtin fns (asked Brian Terlson) (NOTE: there may still be corner cases where builtins will not have `apply()` --- this may need to be reverted on complaint). - HTMLScriptElement#text is an IDL-spec'd attribute, and we use it in all cases --- so the comment was sort of nonsense. - The value of `msie` does not depend on whether the user is using a "real" browser or not. Closes #10242
|
I'll fix up and merge. Thanks @caitp |
|
I already merged... I guess I'll amend this, unless you're doing it pete. THe commit message is wrong anyways |
|
Oh, OK. Amend away. I was wondering why I was getting conflicts :-) |
FWIW --- so in that case there may not be much we can do anyways (console.log.apply) |
Doesn't that mean that calling console.log in your application would cause exceptions whenever you don't have the console open? |
|
That's exactly what it means. |
No description provided.