Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/HTML Compiler): replaced 'locals' with 'scope' #10018

Closed
wants to merge 1 commit into from
Closed

docs(guide/HTML Compiler): replaced 'locals' with 'scope' #10018

wants to merge 1 commit into from

Conversation

chatchavan
Copy link
Contributor

'locals' is an obsolete syntax

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@chatchavan
Copy link
Contributor Author

I signed the CLA. I have no idea how to edit the email address associated with this commit. :(

@caitp
Copy link
Contributor

caitp commented Nov 12, 2014

@chatchavan: git commit --amend --author="name <email@address>" --- the fix looks okay to me, please fix up the commit email and ping me

@caitp caitp added this to the 1.3.4 milestone Nov 12, 2014
@caitp caitp self-assigned this Nov 12, 2014
@chatchavan
docs(guide/HTML Compiler): replaced 'locals' with 'scope'
075fc7d 
In "Understanding How Scopes Work with Transcluded Directives" section, a text referred to an obsolete 'locals' instead of 'scope'.
@chatchavan
Copy link
Contributor Author

Done.

caitp pushed a commit that referenced this pull request Nov 14, 2014
@chatchavan @caitp
docs(guide/compiler): replaced 'locals' with 'scope'
eec78e7 
In "Understanding How Scopes Work with Transcluded Directives" section, a text referred to an
obsolete 'locals' instead of 'scope'.

Closes #10018
@caitp caitp closed this in 7f857e4 Nov 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@caitp caitp

Labels
cla: no type: docs
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chatchavan @mary-poppins @caitp