This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
ngAnimate late ngShow resolving behavior in v1.3.0-rc.1 #9103
Closed
Description
Did start testing AngularStrap with the recent release candidates, and I've found out one pretty serious regression regarding animations:
When you use $animate.enter
on a DOM element (eg. a tooltip), any ng-show
attribute on this base DOM element was properly handled in v1.2, while it has a noticeable delay in v1.3.
For instance, if I have a template with an ng-show
that resolves to false
and that I'm using $animate.enter
on it, I'll get a flicker as the entering animation will play, and only once finished, the ng-show
will be resolved and properly applied, making the element disappear (and thus flicker).
Reproducible example, typeahead with data-min-length=0
(uses an ng-show
attr), just focus the input to see the flicker issue.
- v1.2: http://plnkr.co/edit/FvuDaz5C8gFGXPM6ftFm?p=preview (working)
- v1.3 : http://plnkr.co/edit/0eAGWOz3DfWgwjryjVDJ?p=preview (broken)
- typeahead template: https://github.com/mgcrea/angular-strap/blob/master/src/typeahead/typeahead.tpl.html
- typeahead $animate.enter (tooltip): https://github.com/mgcrea/angular-strap/blob/master/src/tooltip/tooltip.js#L214