ngSwitch removes DOM elements twice

[matsko]

The code up here:
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngSwitch.js#L150

May seem to contain elements that are called here:
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngSwitch.js#L159

The issue may relate to transclusion blocks that were added in:
ac37915

[btford]

@matsko is this a regression?

[IgorMinar]

not a regression, but a perf issue.

functionality is not affected, we just do work unnecessarily as far as I can tell.

[thebigredgeek]

Like this? #8833

[caitp]

The referenced sha specifically fixes an issue where DOM nodes were attempted to be removed twice (resulting in a type error), but it's quite likely that there are more problems with it

[thebigredgeek]

Part of the problem is that the callback for the $animate.leave will always reference the last value of i in that loop. There is a closure issue there.

[IgorMinar]

I just spoke with @matsko about this one. there is one test that fails if the direct removal is removed (:)).

we think the test is no longer valid or was never valid and @matsko is going to handle that.