Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Refactor $parse #7540

Closed
Closed
@IgorMinar

Description

@IgorMinar

We need to make a major cleanup in $parse as it contains a lot of legacy code that is not needed.

The work should be broken down into 3 PRs so that it's easier to review:

1/ remove support for JSON parsing (this is a feature that is not exposed via public api and the code just sits there for no good reason)
2/ remove support for promise unwrapping (this a deprecated feature, which we want to remove in 1.3)
3/ benchmark the impact of removing function generation (via new Function) and only to our simpleGetterFn implementation. This needs to be done across browsers - mainly IE9, IE 11, latest Firefox, latest Chrome, mobile Chrome and mobile Safari. Depending on the results, we should remove or keep this code path.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions