Error while evaluating requestAnimationFrame(fn) in angular.js:11328 for old browsers

[chandan-singh]

Version: Angular.js 1.2.14
Line-number: 11328

In older version of browsers (such as QtWebKit), requestAnimationFrame was not available so when user migrate from 1.2.13 to 1.2.14, she may encounter following error: "'undefined' is not a function (evaluating 'requestAnimationFrame(fn)')". In my case , it is being called from angular.js:9509.

[lefos987]

Hi @chandan-singh . Thank you for this. Can you please provide an example that reproduces this issue for you? Is this something that happened only for QtWebKit or did you get the same problem in other browsers as well? If yes, which are these "old browsers" that cause the issue?

[functionportal]

Any browser that doesn't support this: https://developer.mozilla.org/en-US/docs/Web/API/window.requestAnimationFrame will get function undefined errors.

[lefos987]

This is introduced by commit 04d7317
Check #6535 and #6601 where a similar issue is already raised.
There is an open PR #6540 to fix the issue for old versions of FF.

[IgorMinar]

we should add moz prefix to

angular.js/src/ng/raf.js

Lines 5 to 9 in 04d7317

	var requestAnimationFrame = $window.requestAnimationFrame ||
	$window.webkitRequestAnimationFrame;
	var cancelAnimationFrame = $window.cancelAnimationFrame ||
	$window.webkitCancelAnimationFrame;

and create a fallback via $timeout for browsers that don't have rAF.

@matsko what do you think?