short is a reserved keywork

[jeremistadler]

FIX: Put quotation marks around the property definition at:

function $LocaleProvider(){
..
DATETIME_FORMATS: {
short: 'M/d/yy h:mm a',

[jeffbcross]

Confirmation that short is a reserved keyword in ECMAScript 2+: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words

The file in question is src/ng/locale.js

[RichardLitt]

Given that #5342 fixes this, should this issue still be labelled as 'PRs plz!'?

[RichardLitt]

Actually, I'm not sure this needs to be done, at all. 'short' was pulled as a reserved keyword for ECMA5. There are several packages used in angular which also use short inappropriately if we're being backward compatible:

• grunt
• grunt-contrib-clean
• decompress-zip
• optimist
• bower-registry-client
• bower-json
• bower

As well, short is used as an id here:

• i18n/spec/closureI18nExtractorSpec.js
• i18n/src/converter.js

Basically, most of those packages won't update, as node runs on a minimum of Ecma5. Finally, as Angular 2.0 will be entirely in ECMA6, I think it's safe to simply not do this for now.

[mrzepinski]

@jeffbcross @RichardLitt This is very problematic. I use angular.js in my code and when I am building my code using Maven and YUI Compressor it throws an errors based on this reverved short property.

[jeffbcross]

@mrzepinski can you verify that #5342 fixes your issue?

[mrzepinski]

@jeffbcross Jep. That is fine. It could be merged to the master branch and realeased with next version.

[RichardLitt]

👍