Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

urlResolve pathname fix for file protocol + windows should be moved to location #5041

Closed
@jeffbcross

Description

@jeffbcross

The private urlResolve method was recently patched to strip the drive name from path names on windows when using the file protocol.

f925e8c
89f435d

While this fix was necessary to make the $location service work correctly with the file protocol on windows, the fix should be implemented in $location instead of in urlResolve. The low-level behavior is actually desirable given that the notion of relative paths in the file protocol is not legitimate, and the urlResolve method should not be very opinionated on how its properties are used by different angular services.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions