Compilation warning from "grunt package"

[benmccann]

It would be great to fix this since it's the only warning and then make warnings into errors so that we maintain a warning-free state:

$ grunt package

build/angular.js:10124: WARNING - Throw expression is not a minErr instance.
            throw e;
            ^

0 error(s), 1 warning(s)

[btford]

This is something you'd have to special-case in minErr.

PR welcome :)

[benmccann]

I'm not super familiar with that. Does that mean the changes would go into the ng-closure-runner project instead of this one?

[btford]

probably. @ksheedlo knows more than I do about this. :)

[ksheedlo]

Right. The problem with this is it's a rethrow case. We know the code that
causes the warning throws MinErr. The exception needs to be checked and
rethrown, which confuses the compiler and causes the warning. The solution
to this is to write a new minerr pass implementation using closure compiler
type annotations. It will need work in both ng-closure-runner and angular
itself.

I've got a lot of stuff on my plate right now, but I can try and fast track
the fix so we can have it maybe before we get out of RC. A lot of folks
have asked for it.

[benmccann]

Looks like we're still getting this when I run grunt

[IgorMinar]

yes. we need to decide how to deal with rethrown exception with minErr. this is a currently unresolved problem, but it's not a significant issue so we deprioritized it.

if anyone has a proposal and wants to send a PR then that would be great.