What about offset() method in jqLite?

[allaud]

One thing I need in built in jQuery is offset function with same result:

angular.element(elem).offset() == {
  width: 100,
  height: 100,
  top: 23,
  left: 400
}

Now we have to use our own service for calculating element offset, but it would be great to have it inside of Angular. Any thoughts?

[steelsojka]

I had to do the same thing in a project. I would love to implement this unless someone objects.

[janmarek]

What about using real jQuery?

[allaud]

@janmarek there is no point to use real jQuery just for one method

[steelsojka]

I'm thinking of just implementing the getter portion of offset and not the setter portion. The setter might be a little heavy for jqlite. Thoughts?

[allaud]

@steelsojka the getter portion it enough, because you can use .css() method to set different element properties. And there are a lot of cases when we need to calculate offset:

• positioning autocomplete suggest
• positioning tooltip block
• etc.

[steelsojka]

Here's my commit for this: steelsojka@fa137ee

[allaud]

@steelsojka what about height/width data in offset() result? And what about older browsers support?

[steelsojka]

Does the height and width come back currently in jQuery's implementation? It can be added but I wan't sure if jqLite was trying to match jQuery's API 1 to 1. I'll check on the browser support. I forgot window.pageYOffset isn't supported on older browsers. I'll make a couple of adjustments.

[allaud]

@steelsojka the other way is to implement height/width methods

[allaud]

@steelsojka did you make a PR?

[steelsojka]

Pull request: #3799

[porjo]

+1

@steelsojka according to this SO post your implementation (using getBoundingClientRect) won't take scrolling into consideration. Can you confirm?

[maxazan]

+1
it will be very useful

[brunowego]

+1