Link fn of a replace+transclude directive runs before transclusion takes place

[aeby]

I'm unable to access transcluded elements in a link function. The behavior has changed since 1.1.5. See http://plnkr.co/edit/WvGAlByx1771wurPbWXA?p=preview and compare the result with the commented 1.1.5 script

app.directive('test', [function () {
  return {
    restrict: 'E',
    transclude: true,
    replace: true,
    template: '<div ng-transclude></div>',
    link: function postLink(scope, element) {
      // This should log 2 as in 1.1.5
      console.log(element.children().length);
    }
  };
}]);

element.children(); should contain the transcluded elements like the `h2' tags:

<test>
    <h2>I'm transcluded</h2>
    <h2>Me too</h2>
<test>

[bobslaede]

http://plnkr.co/edit/PFtqmLwPKX4UJbLOEGtg?p=preview

Your example was broken

[aeby]

@bobslaede Thanks for the fix.

[flyingmutant]

I can confirm this bug — my directives became broken after upgrade from 1.1.5 to 1.2.0-rc1.

[aeby]

It looks like the compile order has changed (maybe here 683fd71). If I transclude a directive that uses the same parent controller as my directive does (e.g. I wrap an <input> in a custom <formfield> directive and both require: '^form') prior to 1.2rc1 the common controller was already initialized by the transcluded directive.
I don't know if this is a bug or if this is the intended behavior.

[bobslaede]

I don't think it is intended behavior, when the dom is not "ready" for the post-link function.
I can see how it is not ready for the compile, and pre-link function.
I can't find any tests that describe that the pre and post link functions should have access to transcluded elements.

[aeby]

Yes I guess you are right, the dom has to be ready in the post-link function.

[bobslaede]

I'm guessing its the $scope.$evalAsync method call. There's no way to know when that is done.
I will try debug some stuff locally :)

[bobslaede]

Changing $evalAsync to just $eval makes everything available in both pre and post link. Maybe there's some performance gain here? Somebody must know :)

[aeby]

Do you talk about this 683fd71#L0R56 $evalAsync?

[bobslaede]

Yeah, that one

[aeby]

So I guess @IgorMinar should know :)

[bobslaede]

Changing $evalAsync doesn't help that bug with ng-include sadly...

[bobslaede]

I just had a chance to run the unit tests, they fail with the "fix".
$compile controller should instantiate controllers in the parent->child->baby order when nested transluction, templateUrl and replacement are in the mix FAILED