AngularJS unescapes matrix parameters

[bourey]

I'm submitting a ...

• bug report
• feature request
• other (Please do not submit support requests here (see above))

Current behavior:
AngularJS un-escapes matrix parameters, preventing matrix parameters with slashes from being used in dual-router AngularJS / Angular applications.

Expected / new behavior:
AngularJS should not un-escape matrix parameters.

Minimal reproduction of the problem with instructions:
In a hybrid setup, add a link like: <a [routerLink]="['/a/ng2', {path: '/some/path'}]">ANGULAR A
While Angular properly renders this link as "http://localhost:4200/a/ng2;path=%2Fsome%2Fpath", AngularJS rewrites it as http://localhost:4200/a/ng2;path=/some/path during navigation. Depending on the setup, this causes the application to display either a missing route mapping or a redirect loop.

AngularJS version: 1.5+

Browser: all

[petebacondarwin]

This sounds like a valid bug. Thanks for reporting @bourey !

[petebacondarwin]

Is it $location or $route that is doing the rewriting?

[jasonaden]

@petebacondarwin I think it's $location. I've looked at this encoding/decoding before and I think it's all from $location.

[petebacondarwin]

I think the exact problem here is that we are unescaping forward slashes, right?
We have tests that check that we unescape other special characters.
Can anyone point me to the spec for these matrix params? I can't find anything official.

[petebacondarwin]

I have created a PR for this: #16316 - please take a look. As with all things related to the can of worms that is $location fixing this bug could well create problems with loads of other use cases.