Angular $http - handle differently xhr.onabort, xhr.ontimeout and xhr.onerror

[jtassin]

I'm submitting a ...

• bug report
• feature request
• other (Please do not submit support requests here (see above))

Current behavior:
$httpBackend handles xhr.onabort and xhr.ontimeout the same way than xhr.onerror.

It is a problem when using an error handler on $http(config). Typically, in my company, we resend http errors to our server and we currently can't exploit those errors to detect timeout or real http error (too much false positives from aborted requests). This is the object that the handler get :

{data: null, status: -1, config: Object, statusText: "", headers: function}

Expected / new behavior:
A very usefull result could be to that the handler get something like :

• for abortion

  {data: null, status: -1, config: Object, statusText: "abort", headers: function}

• for timeout

  {data: null, status: -1, config: Object, statusText: "timeout", headers: function}

• for other errors

  {data: null, status: -1, config: Object, statusText: "", headers: function}

Minimal reproduction of the problem with instructions:

When I run this code :

$http({
  timeout: canceller.promise,
  method: 'GET',
  url : 'https://Idonotexist'
}).catch(vm.errorHandler);

I expect than vm.errorHandler can handle differently aborted errors than other errors.
But it always get

{data: null, status: -1, config: Object, statusText: "", headers: function}

For all three errors (error/timeout and abort)

Here is a jsfiddle to reproduce it easilly.

Angular version: 1.6.4

Browser: [all]

Anything else:
Here is the $httpBackend code :

var requestError = function() {
  // The response is always empty
 // See https://xhr.spec.whatwg.org/#request-error-steps and https://fetch.spec.whatwg.org/#concept-network-error
  completeRequest(callback, -1, null, null, '');
};

xhr.onerror = requestError;
xhr.onabort = requestError;
xhr.ontimeout = requestError;

It could be nice to change it to :

(

angular.js/src/ng/httpBackend.js

Line 105 in 0784977

var requestError = function() {

) :

var requestError = function(statusText) {
  return function() {
    // The response is always empty
    // See https://xhr.spec.whatwg.org/#request-error-steps and https://fetch.spec.whatwg.org/#concept-network-error
    completeRequest(callback, -1, null, null, '');
  }
};

xhr.onerror = requestError('');
xhr.onabort = requestError('abort');
xhr.ontimeout = requestError('timeout');

[frederikprijck]

Thanks for the Feature request. Even tho it's going abit slower as expected, I am working on this which you can track here: #15847

Status: Most of the code is implemented, most of it is tested. I need to add some more tests and update the docs.

It will most likely be a bit different as to you propose. Currently it'll include complete, error, timeout and abort.

[jtassin]

@frederikprijck : thx a lot.
Sorry, I didn't see your PR.

[Narretz]

Let's keep this open to track the issue-part of this change.

[ludovicthomas]

Thanks, it will help a lot. As the 1.6.5 was out 3 days ago, do you have a target date for 1.6.6 or 1.7.0?

[gkalpak]

No concrete dates yet. Here are my rough estimates:

• 1.6.6 should be out in a couple of weeks (we are working on some infrastructure changes for our docs and website, so we should roll out a release as soon as that's in place).
• 1.7.0 should be out some time around October (but don't quote me on this 😛)