Uncaught ReferenceError: Node is not defined

[MaestroJurko]

angular.js:2789 Uncaught ReferenceError: Node is not defined

Updated from 1.4.7 to 1.4.8

[Narretz]

Please provide more context information; stacktrace, minimal demo etc.

[MaestroJurko]

This happens on specific d3 charts. Will try to create an example, but it works with 1.4.7 version. I see that there were some changes on jqlite. Probably that is the reason.

I am using jquery, did how to use jquery + angularjs changed?

[jlmitch5]

No coverage information was collected, exit without writing coverage information
/Users/jmitchell/tower_fork/node_modules/angular/angular.js:2789
var jqLiteContains = Node.prototype.contains || function(arg) {
                     ^

ReferenceError: Node is not defined
    at /Users/jmitchell/tower_fork/node_modules/angular/angular.js:2789:22
    at Object.<anonymous> (/Users/jmitchell/tower_fork/node_modules/angular/angular.js:29016:3)

It's happening after require("angular/angular"); in the traceback

Bumping angular to be specifically 1.4.7 fixes the issue.

[Narretz]

Ah, I see it's a change that has been made to jqlite which relies on Node. I'm not sure how that's fixable for server use of angular.

[Narretz]

Actually, how exactly do you use Angular with require? In the browser or on the server?

[jlmitch5]

@Narretz I inherited this flow, and I haven't dove too deep/know if its best practice, but we require angular when building the app for testing.

We take several client JS libraries through require, and then set up these to be found on window.

[neha-nsharma]

I am getting the same exception with the mocha tests after upgrading to angular 1.4.8

var jqLiteContains = Node.prototype.contains || function(arg) {
^
ReferenceError: Node is not defined
at .../angular/angular.js:2789:22

[Narretz]

@gkalpak ping because you committed the change that causes this. Do you think this is something we should account for?