Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(tutorial): Code samples use deprecated $http promise methods #12755

Closed
@rabdill

Description

@rabdill

The tutorial (website, repo) looks like it might be due for at least a few minor changes. In particular, starting in step 5, it sets up a call using the $http service like this:

phonecatApp.controller('PhoneListCtrl', function ($scope, $http) {
  $http.get('phones/phones.json').success(function(data) {
    $scope.phones = data;
  });

  $scope.orderProp = 'age';
});

When, according to the most recent docs, we aren't supposed to do that anymore. I'd be happy to move everything into using the .then() method, but this would also require fixing the angular-phonecat repo that's used in the tutorial, and I'm not sure if there's a particular process in place for coordinating changes so they line up properly. (Also, to be honest, I have no idea how you've been dealing with pushing changes through all the phonecat "releases" retroactively without someone dying in a rebasing accident.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions