angular.element.css() method has undocumented inconsistentcy with jQuery api

[adam77]

"When a number is passed as the value, jQuery will convert it to a string and add px to the end of that string."
http://api.jquery.com/css/#css2

jqLite does not appear to do this.

Can result in some nasty subtle bugs which only show up when jqLite in use.

[petebacondarwin]

@mzgol can you take a look at this?

[mgol]

I wish jQuery didn't do it. :) This basically means any new CSS property that might accept plain numbers as values needs to be added to a whitelist that we maintain; we've recently had to add flexbox-related properties to the list.

A current list can be viewed at http://api.jquery.com/jQuery.cssNumber/, we've made this object public recently.

That said, we haven't removed this mechanism exactly because it might broke a lot of code and it won't throw errors but just won't apply some CSS rules so it might, indeed, be hard to debug. This would be pretty trivial to add to jqLite, maybe we should do it for compat with jQuery.

This would be a breaking change for jqLite, though so we shouldn't touch it in 1.3 IMO.

[petebacondarwin]

Let's add it as a candidate for 1.5 and just merge the doc update (#11614) for now.

[mgol]

Makes sense, this API requires one to react to new CSS properties so it adds responsibility for jqLite maintenance if we do want to match this jQuery design mistake. ;)

[adam77]

jQuery reference:

• convert parameters of type number
• list of props not to add 'px' to ('possibly unitless')

[mgol]

@adam77 No need to link to source, it's officially documented under http://api.jquery.com/jQuery.cssNumber/ with more info than in the code as I mentioned in my comment #11626 (comment)