using ngResource when property name starts with @

[ronaldjeremy]

I have objects that have properties that begin with @. Example "@itemid" (this from the BadgerFish convention of turning an XML document into JSON, so i need to stick with this namaing convention)

I cannot figure out how to get a configuration object that ngResource will accept. For example i have tried:
$scope.menuResource = $resource(url + "/restapi/items/:itemID", {itemID: "@@itemid"});
and Angular will throw an error:badmember exception.

How can I escape the @ in the property name to get it to work with ngResource?

[gkalpak]

Currently, ngResource only supports looking up properties containing alphanumeric characters, underscrores or dollar-signs:

var MEMBER_NAME_REGEX = /^(\.[a-zA-Z_$][0-9a-zA-Z_$]*)+$/;

function isValidDottedPath(path) {
  return (path != null && path !== '' && path !== 'hasOwnProperty' &&
      MEMBER_NAME_REGEX.test('.' + path));
}

It should be an easy change, adding more characters to the MEMBER_NAME_REGEX (e.g. @), but I am not sure what other implications might arise.

Is anyone aware why the original MEMBER_NAME_REGEX only allowed 0-9a-zA-Z_$ ?

[ronaldjeremy]

Thanks gkalpak! So given his isolation of the relevant code, devs do you think this is something that can be easily added?

[ronaldjeremy]

So I made a tiny change to line 13 in angular-resource.js:

var MEMBER_NAME_REGEX = /^(.[a-zA-Z_$@][0-9a-zA-Z_$]*)+$/;

This works in my application when i use for example {itemID: "@@itemid"}

So far i haven't noticed any side effects. How can I go about having this change included in the official distribution?

[gkalpak]

You can submit a Pull Request (including the fix and appropriate test-coverage).
For more details and useful pointers, take a look at CONTRIBUTING.md#submitting-a-pull-request.

[ronaldjeremy]

@gkalpak I am following your instructions on Pull Requests and it says i need to create a new branch -- but it does not appear i am allowed to create a new branch at https://github.com/angular/bower-angular-resource

It it something you have permission to do?

[gkalpak]

You need to fork the repo (the main angular.js, not bower-angular-xyz), create a branch on your fork, make the changes and submit a pull request against the original (forked) repo.

The process is discribed in more detail here.

[mustela]

Just pushed a PR for this one.