bug(ngAria): ng-click evals attrs.ngClick without passing locals

[kentcdodds]

Here's an example of the bug. What's happening is ngAria has this line:

scope.$eval(attr.ngClick);

It should probably be:

scope.$eval(attr.ngClick, {$event: event});

Can't think of anything else that is an expected expression local that isn't on the scope, but if there are, we'd need to make sure those made it in there as well...

pinging @marcysutton on this one.

[caitp]

There are a few improvements to make for this:

1. Yes, pass $event as a local
2. Parse the expression before-hand, use the same security features as core ngClick (https://github.com/angular/angular.js/blob/master/src/ng/directive/ngEventDirs.js#L60)
3. Evaluate the expression for ngDblClick too
4. Restrict ngDblClick to attributes only

[caitp]

There are other problems:

Changes to bindings which occur during the event handler installed by aria's ngClick will not update the DOM --- because they don't cause a digest.

[gkalpak]

@caitp: I wonder if pressing enter or spacebar should execute the dblclick handler (from an aria point of view). In any case, I don't think it's a good idea to execute both.

👍 for restricting ngDblClick to attributes only.

[marcysutton]

High-five for fixing this @caitp, the original PR was intended to be a starting point.