$filter number: Could we display an Infinity symbol in case of Infinity value?

[QuentinFchx]

Could we display an Infinity symbol (∞) instead of an empty string through the "number" filter, when it's applied to Infinity/-Infinity?
According to this thread, we could use ∞ or ∞ (decimal) or ∞ (hex)

I can come with a PR if it's in the framework's scope. I guess we only have to add a case here.

[caitp]

I wonder if CLDR includes localized "infinity symbols", hah. @petebacondarwin wdyt? Doesn't seem like a big deal to me (I would label this as "Good First Bug" if we had the label already)

[caitp]

@QuentinFchx you can submit a PR, I'll be happy to review it, it doesn't seem unreasonable and it's pretty low impact so go for it.

It should be pretty obvious what to do --- check if abs(number) is Infinity, and if it is, return a symbol (if CLDR does actually localize this, we should use a localized version if available, but I doubt it does). Then just add some tests demonstrating that it does work correctly. Should take all of 10 minutes to write up.

[QuentinFchx]

Thanks for your quick answer !

I started to dive into the filter's code.
Should I add this feature into the directive's code or into the format function that is shared with the currency directive ?
Modifying the format function will avoid code duplication (especially to handle the negative infinity), but we'll have to inject $locale to retrieve the Infinity symbol. Might that cause any issue ?

Also, there is no Infinity symbol in the locales. Should we add it there aswell ?

[caitp]

I'm half-joking about localizing the infinity symbol --- I expect there's no CLDR data for localized Infinity. If someone proves me wrong then sure, but that's a bigger project than this and it's not worth going for it just for this

[QuentinFchx]

Might this line kill Buzz Lightyear dreams (and mines too ?) then ?

[caitp]

well if they're getting that from CLDR then we probably do want to add that --- but for this patch I wouldn't worry about it.

[QuentinFchx]

Fine !
Do we still agree on modifying the format function and not the directive's code to avoid code duplication (again, meaning that the currency filter will be impacted) ?

[caitp]

I never agreed on that in the first place, but do it how you like