angular-mocks strictDi mode doesn't work because of missing annotation on $RootScopeDecorator

[swar30]

If attempting to run tests with

angular.mock.inject.strictDi(true)

tests will fail with missing annotation for $RootScopeDecorator which is defined in angular-mocks.js

The code to blame is (74981c9#diff-2a255ed5e9564e25ce6eb711b604f40fR2046)

angular.mock.$RootScopeDecorator = function($delegate) 

It should be like the rest of the decorators defined, like

angular.mock.$RootScopeDecorator = ['$delegate', function($delegate) 

[shahata]

our tests should have discovered this, I'm looking into the reason why they didn't fail

[shahata]

OK, the reason is that fn.$inject was set in a previous test that didn't enforce strictDi, and so when we got to a test that enforces strictDi, the fn.$inject was already set. Question is if there is anything we can do about it (and if we should)... maybe we can simply have strictDi enforced in every test.

[caitp]

we have had strictDi errors before that have caught bugs in minified angular modules before (eg ngMessages), we could just fix this one and move on --- running all the tests with strictDi is not super realistic (it means using explicit annotations for all of our little inline module definitions and it's just a huge refactoring). I'm not saying we couldn't do it, but it is just hard :( (currently, config blocks get to use the "nice" annotation style, but if they use $compileProvider or whatever and register something injectable, they're out of luck, and there's no real way to differentiate between the "test" provider that gets to use easy-annotations, and the "real" provider that the library uses, so that's not really fixable).

[swar30]

Any ETA on this, need to know if I need a work around or just wait for upcoming release