AngularJS 1.3.2 -> 1.3.3 broken filter name parsing (?)

[enapupe]

My filters stopped working after updating from 1.3.2 to 1.3.3.

Check the fiddle with 1.3.2 working http://plnkr.co/edit/30JRSb1VlHygqURtmvZc?p=preview fine with dot in the name and the same fiddle with 1.3.3 http://plnkr.co/edit/bwVehJ65lmHIH5wL2aRW?p=preview which is raising Error: [$injector:unpr] Unknown provider: afilterFilterProvider <- afilterFilter http://errors.angularjs.org/1.3.3/$injector/unpr?p0=afilterFilterProvider%20%3C-%20afilterFilter

Both versions works just fine when the filter has no dot (.) in the name.

[gkalpak]

Duplicate of #10054 and #10110.

[petebacondarwin]

We never intended filters to be given names that were anything other than straight identifiers. This means that dots and dashes and other special characters should not appear in their names.

[enapupe]

And I never intended to write a code that is now broken. I don't think that is the point.

[rent-a-developer]

This is very bad decision!
If you did not indent that filter names could include characters such as a dot, then why didn't you mention that in the documentation???
Anyways: If it was allowed before, then do not disallow it now. This is a huge breaking change.
You just screwed up a lot of existing code!

Before we could used something nice like this:
{{ 'Translation~LoginView.LoginButton.Caption' | App.Common.Translate }}

Which is now impossible thanks to this amazing "bug fix".

You do realize that we are using object oriented programming nowadays (something like a class that is actually IN a namespace)?
And you do realize that in big applications you need something to separate different modules of your app (let's say something like a namespace)?
And therefore you need to be able to use at least the dot character in filter names.
Do you have any idea of software design and software architecture???

Oh and by the way: Why do you constantly introduce breaking changes in MINOR builds?
You at most do that in MAJOR builds. Developers do not usually expect breaking changes in MINOR builds (well actually 1.3.2 > 1.3.3 is not even a MINOR version change it's just a BUILD version change).
Man this is really frustrating. It seems that a great part of the JavaScript/HTML community doesn't have a single clue about professional software development.

[petebacondarwin]

@rent-a-developer - please read and respect our Code of Conduct when commenting on issues.

Regarding this concern:

• filters are Angular components in the same way as services, directives and controllers. All these components are consistently defined by a name, which is always a simple identifier. I am sorry if this is not clearly defined in the documentation
• filters are also injectable services, identified by their name followed by the word Filter. It would not make sense to allow a non-identifier as a filter name for dependency injection:
  js controller(X, function(App.Common.TranslateFilter) { ... });
• Even though dots and dashes are not available, you can always use capitalization and underscores to distinguish parts of a filter identifier to help with namespacing: appCommonTranslate.

Again, I am sorry that you were using Angular in this undocumented and unsupported way. I hope you can see that this was an inconsistency that has now been tightened.

[petebacondarwin]

This restriction to filter names has been documented since November. See d3fb8dd

We should include this information in more parts of the docs to make it easier to find. In particular I am going to update the docs for Module.filter, $filterProvider.register.

[petebacondarwin]

I have added this documentation here: 4f12ed0

I appreciate that Angular 1's version policy can be confusing, given that many people like to use semver for their versioning; especially in npm and bower. Angular 1 does not strictly follow semver. Instead it has a well defined policy, which I have added to a section in the FAQ : 67af519