Proposal: .ng-prefilled class helper

[lufzle]

This would be handy in the following use case:

You want to show validation messages either

• after the form is submitted
• on field touch, provided the field has already a value. In this case I'd like the user to notice the validity of the new value right after touch -- instead of waiting until form submission.

So it would work like this (relevant classes mentioned):

1. the field is in a untouched state, but has a value: ng-untouched ng-pristine ng-prefilled
2. user changes field value: ng-untouched ng-dirty ng-prefilled
3. user blurs field: ng-touched ng-dirty ng-prefilled

Does this makes sense to you, guys?

[caitp]

it sounds interesting, but oh god forms are a nightmare already --- if it's complex to add this, then I don't think we should bother. Would you be interested in hacking together an implementation so we can see how bad it would be?

[Narretz]

prefilled is probably too specific - but I can see adding a class when the control / view is not empty (has length for text based inputs). However, that means we need to special case checkbox, radio, probably select too?

[lufzle]

Yes, I think it should go everywhere as long as there's an initial value in
the ngModel.

On Fri, Nov 14, 2014 at 2:07 PM, Narretz notifications@github.com wrote:

prefilled is probably too specific - but I can see adding a class when
the control / view is not empty (has length for text based inputs).
However, that means we need to special case checkbox, radio, probably
select too?

—
Reply to this email directly or view it on GitHub
#10050 (comment)
.

[Narretz]

Just to clarify: I mean the supposed class would be added any time a control had a viewValue, regardless of the ngModel state. This would include initial values only if they get through the formatter, and user entered values regardless of validity. This should work for you initial example. (Though I'm still not 100% sure the whole thing is necessary, becasue you should be able to add a class to a control via viewChangeListener)

[Narretz]

Ah, okay I see what you mean. Display it on blur when the control value has an initial value set from the model ... I think that's too specific.

[lufzle]

Yeah, I agree it looks like a very specific case. :)

On Fri, Nov 14, 2014 at 8:34 PM, Narretz notifications@github.com wrote:

Ah, okay I see what you mean. Display it on blur when the control value
has an initial value set from the model ... I think that's too specific.

—
Reply to this email directly or view it on GitHub
#10050 (comment)
.

[lufzle]

I was thinking in the specific case where the control has an initial value.
This is, to differentiate whether a value was already there from the
beginning (i.e. no user input; control is in a pristine state), or a value
was inputted by the user. Today there is no way to know this exclusively
via CSS.

I guess a better name could be .has-value maybe?

On Fri, Nov 14, 2014 at 8:20 PM, Narretz notifications@github.com wrote:

Just to clarify: I mean the supposed class would be added any time a
control had a value, regardless of the ngModel state. This would include
initial values and user entered values regardless of validity. This should
work for you initial example. (Though I'm still not 100% sure the whole
thing is necessary, becasue you should be able to add a class to a control
via viewChangeListener)

—
Reply to this email directly or view it on GitHub
#10050 (comment)
.

[petebacondarwin]

OK, so ngModel already has a method called $isEmpty(), which is special cased for things like checkboxes and selects. We should be able to add CSS classes for ng-empty, ng-not-empty based on the value of calls to this method. I think that would be sufficient to do what @luisfarzati wants to achieve.