-
Notifications
You must be signed in to change notification settings - Fork 875
docs:(created virtual grid cookbook) #993
base: master
Are you sure you want to change the base?
Conversation
Updated component name to follow "Component" suffix convention + fix path display values in document code samples. |
062b274
to
a75edb0
Compare
Updated outdated PR to rc |
a75edb0
to
d906bfd
Compare
Updated to use core-js shim |
d906bfd
to
043cb80
Compare
Rebased to latest master |
88c30d4
to
2116236
Compare
docs: update component name to have Component suffix + update display value for path in code samples data.json rc img new image core lint update syntax directive
2116236
to
14ed60e
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
I updated it to use ngModules and the latest conventions in code that we were deciding. I also did a quick lecture and I think it is good to go (As soon as Ward checks the English 👍 ) Optionally, since it uses a lot of "related" components and services, we could abstract it to a feature module. |
Thanks @Foxandxss for making those updates. I think it would be great to get this published since it's been sitting for a while now. |
That is the goal, make them ready to publish them soon. |
@wardbell Adding the Virtual Grid cookbook