Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs:(created virtual grid cookbook) #993

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thelgevold
Copy link
Contributor

@wardbell Adding the Virtual Grid cookbook

@thelgevold
Copy link
Contributor Author

Updated component name to follow "Component" suffix convention + fix path display values in document code samples.

@thelgevold thelgevold force-pushed the cb-create-virtual-grid branch 2 times, most recently from 062b274 to a75edb0 Compare May 18, 2016 05:21
@thelgevold
Copy link
Contributor Author

Updated outdated PR to rc

@thelgevold thelgevold force-pushed the cb-create-virtual-grid branch from a75edb0 to d906bfd Compare May 20, 2016 03:10
@thelgevold
Copy link
Contributor Author

Updated to use core-js shim

@thelgevold
Copy link
Contributor Author

Rebased to latest master

@thelgevold thelgevold force-pushed the cb-create-virtual-grid branch 2 times, most recently from 88c30d4 to 2116236 Compare July 14, 2016 03:35
docs: update component name to have Component suffix + update display value for path in code samples

data.json

rc

img

new image

core

lint

update syntax

directive
@Foxandxss Foxandxss force-pushed the cb-create-virtual-grid branch from 2116236 to 14ed60e Compare August 28, 2016 16:42
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Foxandxss
Copy link
Member

I updated it to use ngModules and the latest conventions in code that we were deciding.

I also did a quick lecture and I think it is good to go (As soon as Ward checks the English 👍 )

Optionally, since it uses a lot of "related" components and services, we could abstract it to a feature module.

@thelgevold
Copy link
Contributor Author

Thanks @Foxandxss for making those updates. I think it would be great to get this published since it's been sitting for a while now.

@Foxandxss
Copy link
Member

That is the goal, make them ready to publish them soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants